From 0f16fdb97a47d86a5682e060845c1044dc7c769c Mon Sep 17 00:00:00 2001 From: Bryan Stitt Date: Sun, 13 Nov 2022 21:25:58 +0000 Subject: [PATCH] comments --- TODO.md | 1 + web3_proxy/src/rpcs/blockchain.rs | 1 + web3_proxy/src/rpcs/connection.rs | 1 + 3 files changed, 3 insertions(+) diff --git a/TODO.md b/TODO.md index 5da88057..619dfa04 100644 --- a/TODO.md +++ b/TODO.md @@ -235,6 +235,7 @@ These are roughly in order of completition - [x] test that runs check_config against example.toml - [x] improve sorting servers by weight. don't force to lower weights, still have a probability that smaller weights might be - [x] flamegraphs show 52% of the time to be in tracing. replace with simpler logging +- [x] add optional display name to rpc configs - [-] add configurable size limits to all the Caches - instead of configuring each cache with MB sizes, have one value for total memory footprint and then percentages for each cache - [ ] add block timestamp to the /status page diff --git a/web3_proxy/src/rpcs/blockchain.rs b/web3_proxy/src/rpcs/blockchain.rs index c64e002f..06533123 100644 --- a/web3_proxy/src/rpcs/blockchain.rs +++ b/web3_proxy/src/rpcs/blockchain.rs @@ -68,6 +68,7 @@ impl Web3Connections { // // trace!(%block_hash, %block_num, "saving new block"); + // TODO: this block is very likely already in block_hashes self.block_hashes .insert(*block_hash, block.to_owned()) .await; diff --git a/web3_proxy/src/rpcs/connection.rs b/web3_proxy/src/rpcs/connection.rs index 01c65056..1b846190 100644 --- a/web3_proxy/src/rpcs/connection.rs +++ b/web3_proxy/src/rpcs/connection.rs @@ -447,6 +447,7 @@ impl Web3Connection { } } + // send the block off to be saved block_sender .send_async((Some(new_head_block), self.clone())) .await