From 0fbbd1b34dad748c6a0723b6666397d31a1f32e4 Mon Sep 17 00:00:00 2001
From: Bryan Stitt <bryan@satoshiandkin.com>
Date: Sat, 25 Jun 2022 03:33:49 +0000
Subject: [PATCH] todos

---
 TODO.md                         | 1 +
 redis-cell-client/src/client.rs | 3 +++
 web3-proxy/src/connection.rs    | 1 +
 3 files changed, 5 insertions(+)

diff --git a/TODO.md b/TODO.md
index bfc85fc4..823c8ef1 100644
--- a/TODO.md
+++ b/TODO.md
@@ -61,6 +61,7 @@
     - we can fix this by only `publish`ing the sorted list once a threshold of total soft limits is passed 
 - [ ] emit stats for successes, retries, failures, with the types of requests, account, chain, rpc
 - [ ] automated soft limit
+- [ ] if we send a transaction to private rpcs and then people query it on public rpcs things, some interfaces might think the transaction is dropped (i saw this happen in a brownie script of mine). how should we handle this?
 
 ## V2
 
diff --git a/redis-cell-client/src/client.rs b/redis-cell-client/src/client.rs
index 6e3d1a11..397bc95b 100644
--- a/redis-cell-client/src/client.rs
+++ b/redis-cell-client/src/client.rs
@@ -71,6 +71,9 @@ impl RedisCellClient {
 
         assert_eq!(x.len(), 5);
 
+        // TODO: trace log the result
+
+        // TODO: maybe we should do #4
         let retry_after = *x.get(3).unwrap();
 
         if retry_after == -1 {
diff --git a/web3-proxy/src/connection.rs b/web3-proxy/src/connection.rs
index 2b5cea79..1aa56b25 100644
--- a/web3-proxy/src/connection.rs
+++ b/web3-proxy/src/connection.rs
@@ -526,6 +526,7 @@ impl Web3Connection {
                     // rate limit failed
                     // save the smallest retry_after. if nothing succeeds, return an Err with retry_after in it
                     // TODO: use tracing better
+                    // TODO: i'm seeing "Exhausted rate limit on moralis: 0ns". How is it getting 0?
                     warn!("Exhausted rate limit on {:?}: {:?}", self, retry_after);
 
                     return Err(retry_after);