From 1b7cc2bffe01d1b3899a0ec82fc3070f07efedc6 Mon Sep 17 00:00:00 2001 From: Bryan Stitt Date: Fri, 7 Jul 2023 16:22:49 -0700 Subject: [PATCH] clean trace logging --- web3_proxy/src/stats/stat_buffer.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/web3_proxy/src/stats/stat_buffer.rs b/web3_proxy/src/stats/stat_buffer.rs index 210bc40b..7002c848 100644 --- a/web3_proxy/src/stats/stat_buffer.rs +++ b/web3_proxy/src/stats/stat_buffer.rs @@ -244,7 +244,7 @@ impl StatBuffer { ) .await { - error!("unable to save accounting entry! err={:?}", err); + error!(?err, "unable to save accounting entry!"); }; } } @@ -275,7 +275,7 @@ impl StatBuffer { points.push(point); } Err(err) => { - error!("unable to build global stat! err={:?}", err); + error!(?err, "unable to build global stat!"); } }; } @@ -322,7 +322,8 @@ impl StatBuffer { .await { // TODO: if this errors, we throw away some of the pending stats! we should probably buffer them somewhere to be tried again - error!("unable to save {} tsdb stats! err={:?}", batch_size, err); + error!(?err, "unable to save {} tsdb stats!", batch_size); + // TODO: we should probably wait a second to give errors a chance to settle } points = p;