tornadocontrib/web3-proxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

don't actually change get_logs

Browse Source 
this has its own edge case, but i need more tests before i trust the change
This commit is contained in:
Bryan Stitt 2023-10-29 20:35:25 -07:00
parent e682798364
commit 2724cfa95e
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
web3_proxy/src/block_number.rs
View File

@ -402,11 +402,12 @@ impl CacheMode {
let (block_num, change) =
BlockNumber_to_U64(block_num, head_block.number());
if change {
// TODO: include the hash instead of the number?
trace!("changing fromBlock in eth_getLogs. {} -> {}", x, block_num);
*x = json!(block_num);
}
// TODO: double check this. it scares me
// if change {
// // TODO: include the hash instead of the number?
// trace!("changing fromBlock in eth_getLogs. {} -> {}", x, block_num);
// *x = json!(block_num);
// }
BlockNumOrHash::Num(block_num)
} else {
@ -425,10 +426,11 @@ impl CacheMode {
let (block_num, change) = BlockNumber_to_U64(block_num, latest_block);
if change {
trace!("changing toBlock in eth_getLogs. {} -> {}", x, block_num);
*x = json!(block_num);
}
// TODO: double check this. it scares me
// if change {
// trace!("changing toBlock in eth_getLogs. {} -> {}", x, block_num);
// *x = json!(block_num);
// }
if let Some(app) = app {
// TODO: make a jsonrpc query here? cache rates will be better but it adds a network request