From 7cd7257058d63372ed46c3990d2d025e329ddd57 Mon Sep 17 00:00:00 2001 From: Bryan Stitt Date: Fri, 13 Oct 2023 18:01:11 -0700 Subject: [PATCH] update comments --- web3_proxy/src/app/mod.rs | 1 + web3_proxy/src/rpcs/many.rs | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/web3_proxy/src/app/mod.rs b/web3_proxy/src/app/mod.rs index 5a3f7d84..6ca7138a 100644 --- a/web3_proxy/src/app/mod.rs +++ b/web3_proxy/src/app/mod.rs @@ -1079,6 +1079,7 @@ impl App { if self.protected_rpcs.is_empty() { self.balanced_rpcs.request_with_metadata(web3_request).await } else { + todo!("its not empty") self.protected_rpcs .request_with_metadata(web3_request) .await diff --git a/web3_proxy/src/rpcs/many.rs b/web3_proxy/src/rpcs/many.rs index 77aefe6d..76ab9d16 100644 --- a/web3_proxy/src/rpcs/many.rs +++ b/web3_proxy/src/rpcs/many.rs @@ -34,14 +34,14 @@ use tracing::{debug, error, info, trace, warn}; pub struct Web3Rpcs { pub(crate) name: Cow<'static, str>, pub(crate) chain_id: u64, - /// if watch_consensus_head_sender is some, Web3Rpc inside self will send blocks here when they get them + /// if watch_head_block is some, Web3Rpc inside self will send blocks here when they get them pub(crate) block_sender: mpsc::UnboundedSender<(Option, Arc)>, /// any requests will be forwarded to one (or more) of these connections /// TODO: hopefully this not being an async lock will be okay. if you need it across awaits, clone the arc pub(crate) by_name: RwLock>>, - /// all providers with the same consensus head block. won't update if there is no `self.watch_consensus_head_sender` + /// all providers with the same consensus head block. won't update if there is no `self.watch_head_block` /// TODO: document that this is a watch sender and not a broadcast! if things get busy, blocks might get missed - /// TODO: why is watch_consensus_head_sender in an Option, but this one isn't? + /// TODO: why is watch_head_block in an Option, but this one isn't? /// Geth's subscriptions have the same potential for skipping blocks. pub(crate) watch_ranked_rpcs: watch::Sender>>, /// this head receiver makes it easy to wait until there is a new block