better log when servers skipped
This commit is contained in:
parent
c0afc295ca
commit
b4ca0fb62d
@ -506,7 +506,7 @@ impl Web3Rpcs {
|
|||||||
// TODO: double check the logic on this. especially if only min is set
|
// TODO: double check the logic on this. especially if only min is set
|
||||||
let needed_blocks_comparison = match (min_block_needed, max_block_needed) {
|
let needed_blocks_comparison = match (min_block_needed, max_block_needed) {
|
||||||
(None, None) => {
|
(None, None) => {
|
||||||
// no required block given. treat this like the requested the consensus head block
|
// no required block given. treat this like they requested the consensus head block
|
||||||
cmp::Ordering::Equal
|
cmp::Ordering::Equal
|
||||||
}
|
}
|
||||||
(None, Some(max_block_needed)) => max_block_needed.cmp(head_block_num),
|
(None, Some(max_block_needed)) => max_block_needed.cmp(head_block_num),
|
||||||
@ -1013,28 +1013,28 @@ impl Web3Rpcs {
|
|||||||
let num_conns = self.by_name.read().len();
|
let num_conns = self.by_name.read().len();
|
||||||
let num_skipped = skip_rpcs.len();
|
let num_skipped = skip_rpcs.len();
|
||||||
|
|
||||||
if num_skipped == 0 {
|
|
||||||
let consensus = watch_consensus_connections.borrow();
|
let consensus = watch_consensus_connections.borrow();
|
||||||
|
|
||||||
let head_block_num = consensus.as_ref().map(|x| x.head_block.number());
|
let head_block_num = consensus.as_ref().map(|x| x.head_block.number());
|
||||||
|
|
||||||
|
if num_skipped == 0 {
|
||||||
error!(
|
error!(
|
||||||
"No servers synced ({:?}-{:?}, {:?}) ({} known). None skipped",
|
"No servers synced ({:?}-{:?}, {:?}) ({} known). None skipped",
|
||||||
min_block_needed, max_block_needed, head_block_num, num_conns
|
min_block_needed, max_block_needed, head_block_num, num_conns
|
||||||
);
|
);
|
||||||
|
|
||||||
drop(consensus);
|
|
||||||
|
|
||||||
// TODO: remove this, or move to trace level
|
// TODO: remove this, or move to trace level
|
||||||
// debug!("{}", serde_json::to_string(&request).unwrap());
|
// debug!("{}", serde_json::to_string(&request).unwrap());
|
||||||
} else {
|
} else {
|
||||||
// TODO: warn? debug? trace?
|
// TODO: error? warn? debug? trace?
|
||||||
warn!(
|
error!(
|
||||||
"Requested data was not available on {}/{} servers",
|
"Requested data is not available ({:?}-{:?}, {:?}) ({} skipped, {} known)",
|
||||||
num_skipped, num_conns
|
min_block_needed, max_block_needed, head_block_num, num_skipped, num_conns
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
drop(consensus);
|
||||||
|
|
||||||
// TODO: what error code?
|
// TODO: what error code?
|
||||||
// cloudflare gives {"jsonrpc":"2.0","error":{"code":-32043,"message":"Requested data cannot be older than 128 blocks."},"id":1}
|
// cloudflare gives {"jsonrpc":"2.0","error":{"code":-32043,"message":"Requested data cannot be older than 128 blocks."},"id":1}
|
||||||
Ok(JsonRpcForwardedResponse::from_str(
|
Ok(JsonRpcForwardedResponse::from_str(
|
||||||
|
Loading…
Reference in New Issue
Block a user