From d75a60a09fae8c97f9bcf2c48584016d8015c5eb Mon Sep 17 00:00:00 2001
From: Bryan Stitt <bryan@satoshiandkin.com>
Date: Tue, 14 Jun 2022 06:09:56 +0000
Subject: [PATCH] wip

---
 web3-proxy/src/app.rs         |  1 +
 web3-proxy/src/connections.rs | 11 ++++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/web3-proxy/src/app.rs b/web3-proxy/src/app.rs
index 642752ce..82ee895a 100644
--- a/web3-proxy/src/app.rs
+++ b/web3-proxy/src/app.rs
@@ -83,6 +83,7 @@ impl Web3ProxyApp {
         balanced_rpcs: Vec<Web3ConnectionConfig>,
         private_rpcs: Vec<Web3ConnectionConfig>,
     ) -> anyhow::Result<(Arc<Web3ProxyApp>, AnyhowJoinHandle<()>)> {
+        // TODO: try_join_all instead
         let mut handles = FuturesUnordered::new();
 
         // make a http shared client
diff --git a/web3-proxy/src/connections.rs b/web3-proxy/src/connections.rs
index 1a4f4f3e..cf5e6b13 100644
--- a/web3-proxy/src/connections.rs
+++ b/web3-proxy/src/connections.rs
@@ -90,6 +90,7 @@ impl Web3Connections {
     ) -> anyhow::Result<(Arc<Self>, AnyhowJoinHandle<()>)> {
         let num_connections = server_configs.len();
 
+        // TODO: try_join_all
         let handles = FuturesUnordered::new();
 
         // TODO: only create these if head_block_sender and pending_tx_sender are set
@@ -170,13 +171,15 @@ impl Web3Connections {
                 while let Ok((pending_transaction_id, rpc)) =
                     pending_tx_id_receiver.recv_async().await
                 {
+                    unimplemented!("de-dedup the pending txid");
+
                     let request_handle = rpc.wait_for_request_handle().await;
 
                     let pending_transaction: Transaction = request_handle
                         .request("eth_getTransactionByHash", (pending_transaction_id,))
                         .await?;
 
-                    // unimplemented!("de-dedup the pending txid");
+                    trace!(?pending_transaction, "pending");
 
                     pending_tx_sender.send_async(pending_transaction).await?;
                 }
@@ -333,6 +336,9 @@ impl Web3Connections {
                     pending_synced_connections.head_block_hash = new_block_hash;
 
                     head_block_sender.send(new_block)?;
+
+                    // TODO: mark all transactions as confirmed
+                    // TODO: mark any orphaned transactions as unconfirmed
                 }
                 cmp::Ordering::Equal => {
                     if new_block_hash == pending_synced_connections.head_block_hash {
@@ -386,6 +392,9 @@ impl Web3Connections {
                         if pending_synced_connections.head_block_hash != most_common_head_hash {
                             head_block_sender.send(new_block)?;
                             pending_synced_connections.head_block_hash = most_common_head_hash;
+
+                            // TODO: mark all transactions as confirmed
+                            // TODO: mark any orphaned transactions as unconfirmed
                         }
 
                         pending_synced_connections.inner = synced_rpcs.into_iter().collect();