eddie
379437b720
fix: remove all references to expert mode ( #6675 )
2023-06-01 12:04:16 -07:00
Nate Wienert
02c0dee089
feat: hide logo on swap currency selector modal (and other areas that use CurrencyLogo) for unsupported currencies ( #6659 )
2023-06-01 08:00:02 -10:00
eddie
c55e1af101
fix: reset confirm trade modal state when chain switches ( #6667 )
...
<!-- Your PR title must follow conventional commits: https://github.com/Uniswap/interface#pr-title -->
## Description
<!-- Summary of change, including motivation and context. -->
<!-- Use verb-driven language: "Fixes XYZ" instead of "This change fixes XYZ" -->
Resets the swap component's local state when the chain changes, to fix Confirmation Modal behavior
<!-- Delete inapplicable lines: -->
_Linear ticket:_ https://linear.app/uniswap/issue/WEB-2161/wonky-swap-modal-behavior-after-switching-chains
_Slack thread:_ https://uniswapteam.slack.com/archives/C047U65H422/p1685467094162069?thread_ts=1685459249.400839&cid=C047U65H422
<!-- Delete this section if your change does not affect UI. -->
## Screen capture
### Before
https://github.com/Uniswap/interface/assets/66155195/115e243a-858b-490d-be9e-269174cc7561
### After
https://github.com/Uniswap/interface/assets/66155195/a47b3606-08ac-490f-abc8-01acf2423efb
## Test plan
<!-- Delete this section if your change is not a bug fix. -->
### Reproducing the error
<!-- Include steps to reproduce the bug. -->
1. swap on a l2
2. via the metamask extension (or in whatever wallet), trigger a chain-change event (e.g. from optimism to mainnet)
a. this does not repro if you change chains from within the app selector.
4. fill in the input details for a new trade (ideally with different tokens so you can notice the bug easily)
5. see that the Confirm Swap modal opens automatically when it shouldn't, and it has the wrong trade details
### QA (ie manual testing)
<!-- Include steps to test the change, ensuring no regression. -->
- [x] same steps as above, ensuring the modal behaves correctly
#### Devices
<!-- If applicable, include different devices and screen sizes that may be affected, and how you've tested them. -->
### Automated testing
<!-- If N/A, check and note so it is obvious to your reviewers and does not show up as an incomplete task. -->
<!-- eg - [x] Unit test N/A -->
- [ ] Unit test
- [ ] Integration/E2E test
2023-06-01 10:02:37 -07:00
eddie
87cbd1ab38
fix: use ConfirmSwapModal in expert mode ( #6673 )
...
Fixes the swap flow for users who are still in expert mode and need permit2 approvals for a token
### test plan
added e2e test for full permit2 flow with expert mode enabled.
failing test without the change:
<img width="1394" alt="Screenshot 2023-05-31 at 2 24 12 PM" src="https://github.com/Uniswap/interface/assets/66155195/6a39e039-31b5-4bce-91d2-5e3ebc777378 ">
passing test with change in the CI of this PR
2023-05-31 14:52:04 -07:00
eddie
1090e97bb5
fix: update snapshots ( #6672 )
2023-05-31 16:37:45 -05:00
Nate Wienert
921c6b105f
fix: prevent searchbar from overflowing the bottom of the window viewport (WEB-2099) ( #6645 )
...
fix: prevent searchbar from overflowing the bottom of the window viewport, add scrolling support for inner contents
2023-05-31 10:03:02 -10:00
Vignesh Mohankumar
bc08e9263d
feat: increased debounce swap quote rate ( #6666 )
...
* feat: increased debounce swap quote time
* fix
2023-05-31 15:46:59 -04:00
Jack Short
8c8300a5de
fix: typecheck error in bagfooter ( #6669 )
2023-05-31 13:50:22 -04:00
Jack Short
3f169adcf2
chore: cleaning up buy button states ( #6618 )
2023-05-31 11:34:49 -04:00
eddie
774368f325
feat: page wallet connect txn completed ( #6655 )
...
* feat: add page to wallet_connect_txn_completed event
* feat: unit test
* fix: test
2023-05-30 11:10:16 -07:00
Vignesh Mohankumar
f83f15d37a
fix: reduce ETH amount on mainnet useUSDPrice request to 50 ( #6642 )
2023-05-30 12:30:16 -04:00
Charles Bachmeier
d9f1402576
feat: [DetailsV2] Add Activity Chart Time Period Switcher ( #6653 )
...
* add endButton and new TimePeriodSwitcher component
* add snapshot testing
* add test file
* remove switcher from TabbedComponent
* update snapshots
* update describe
* update padding
* extra return
* as const notation
* update snapshots
* no more abs positioning
* cleanup tests and add dropdown test
* add divider line to tabbed component
* update design to match new specs
---------
Co-authored-by: Charles Bachmeier <charlie@genie.xyz>
2023-05-26 16:06:36 -07:00
Zach Pomerantz
d81cb28010
build: disable scheduled releases ( #6651 )
2023-05-26 14:10:40 -07:00
eddie
b57a5d7ddb
feat: log swap button click ( #6654 )
2023-05-26 10:13:28 -07:00
eddie
e2dd78fd0e
fix: design nits on summary view ( #6623 )
...
* fix: chainId required fixes
* fix: bad merge in e2e test
* fix: remove unused test util
* fix: remove unnecessary variable
* fix: token defaults
* fix: address comments
* fix: address comments and fix tests
* fix: e2e test formatting, remove Maybe<>
* fix: remove unused variable
* fix: use feature flag for swap component on TDP
* fix: back button
* feat: copy review screen UI from widgetg
* fix: modal padding
* feat: add final detail row
* fix: remove widget comment
* fix: update unit tests
* fix: code style consistency
* fix: remove padding from AutoColumn
* fix: update snapshots
* fix: use semantic gaps
* fix: more px and gaps
* fix: design feedbacks
* fix: button radius in summary modal
* fix: design nits
* feat: update design of summary modal
* fix: font weight and vertical spacing
* fix: update snapshots
* fix: css nits
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: re-order functions
* wip: move approval to summary modal
* wip: not working
* feat: update permit2 e2e tests
* feat: tests passing
* fix: swap test
* fix: bad merge
* wip: move approval to summary modal
* wip: not working
* feat: PendingModalContent tests
* feat: useMaxAmountIn
* fix: bad merge
* fix: naming
* fix: modal flicker when refetching trade
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: remove step indicators when only one step
* feat: move content into PendingModalContent component
* fix: lint
* chore: merge
* fix: update tests for new modal
* feat: add l2 chain logo to modal
* feat: add unit test
* fix: correct modal state when moving between steps
* fix: correct modal state when moving between steps
* fix: proper error handling of user rejection of swap
* feat: update e2e test
* fix: typecheck
* feat: design updates, state updates
* fix: comments
* fix: code style improvements
* feat: require trade to be defined
* fix: remove extra props from ThemedTexts
* fix: one more trans
* fix: remove unused export
* feat: remove undefined checks and other fixes
* fix: update test
* fix: add missing dollar sign
* fix: remove null check and update test
* fix: remove max width from detail row value
* fix: remove isOpen prop
* fix: isopen
* feat: refactor approval flow into a hook
* fix: custom error type
* fix: testid fix
* fix: text colors
* fix: add comment
* wip: permit2 modal animations
* fix: entrance animations
* feat: step indicator transitions
* feat: icon aniamtions
* feat: fix spinner icon
* fix: re-organize new code
* fix: svg import
* fix: tradeMeaningfullyDiffers improvement and prepareFlow fix
* fix: address comments
* fix: headerContent prop
* fix: change tooltip to external link
* feat: add comments explaining async state
* fix: test updates
* fix: nits
* fix: design nits
* fix: reduce nesting
* fix: address comments
* test: remove line from test for debugging
* fix: update tests
* fix: address comments
* fix: comments
* fix: update tests
* fix: update tests
* fix: more nesting in test
* feat: correct help center article
* fix: design nits on summary view
* fix: update test
* fix: update snapshots
* fix: update e2e test
* fix: etherscan link
* fix: update error test
* fix: dont show loader unless onchain processing is happening
* fix: update designs and add comments
* fix: update content in test
* fix: update tests more
* fix: test
* fix: reorganize test code
* fix: sentence case in one more test
* fix: mainnet loading indicator on last step
* fix: re-use opacity css code
* fix: testid issue with test
* fix: update copy
* fix: update strings in test
* fix: lint
* fix: modal height and css improvements
* fix: empty
* fix: padding on l2 badge
* fix: lint
2023-05-25 15:57:13 -07:00
eddie
96d6e00ed6
feat: fix help center link ( #6621 )
...
* test: swap flow cypress tests
* fix: use default parameter
* feat: use Swap Component on TDP
* feat: auto nav for TDP tokens
* chore: merge
* chore: merge
* chore: merge
* chore: merge
* fix: remove extra inputCurrency URL parsing logic
* fix: undo last change
* fix: pass expected chain id to swap component
* fix: search for default tokens on unconnected networks if needed
* test: e2e test for l2 token
* fix: delete irrelevant tests
* fix: address comments
* fix: lint error
* test: update TDP e2e tests
* fix: use pageChainId for filter
* fix: rename chainId
* fix: typecheck
* fix: chainId bug
* fix: chainId required fixes
* fix: bad merge in e2e test
* fix: remove unused test util
* fix: remove unnecessary variable
* fix: token defaults
* fix: address comments
* fix: address comments and fix tests
* fix: e2e test formatting, remove Maybe<>
* fix: remove unused variable
* fix: use feature flag for swap component on TDP
* fix: back button
* feat: copy review screen UI from widgetg
* fix: modal padding
* feat: add final detail row
* fix: remove widget comment
* fix: update unit tests
* fix: code style consistency
* fix: remove padding from AutoColumn
* fix: update snapshots
* fix: use semantic gaps
* fix: more px and gaps
* fix: design feedbacks
* fix: button radius in summary modal
* fix: design nits
* feat: update design of summary modal
* fix: font weight and vertical spacing
* fix: update snapshots
* fix: css nits
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: re-order functions
* wip: move approval to summary modal
* wip: not working
* feat: update permit2 e2e tests
* feat: tests passing
* fix: swap test
* fix: bad merge
* wip: move approval to summary modal
* wip: not working
* feat: PendingModalContent tests
* feat: useMaxAmountIn
* fix: bad merge
* fix: naming
* fix: modal flicker when refetching trade
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: remove step indicators when only one step
* feat: move content into PendingModalContent component
* fix: lint
* chore: merge
* fix: update tests for new modal
* feat: add l2 chain logo to modal
* feat: add unit test
* fix: correct modal state when moving between steps
* fix: correct modal state when moving between steps
* fix: proper error handling of user rejection of swap
* feat: update e2e test
* fix: typecheck
* feat: design updates, state updates
* fix: comments
* fix: code style improvements
* feat: require trade to be defined
* fix: remove extra props from ThemedTexts
* fix: one more trans
* fix: remove unused export
* feat: remove undefined checks and other fixes
* fix: update test
* fix: add missing dollar sign
* fix: remove null check and update test
* fix: remove max width from detail row value
* fix: remove isOpen prop
* fix: isopen
* feat: refactor approval flow into a hook
* fix: custom error type
* fix: testid fix
* fix: text colors
* fix: add comment
* wip: permit2 modal animations
* fix: entrance animations
* feat: step indicator transitions
* feat: icon aniamtions
* feat: fix spinner icon
* fix: re-organize new code
* fix: svg import
* fix: tradeMeaningfullyDiffers improvement and prepareFlow fix
* fix: address comments
* fix: headerContent prop
* fix: change tooltip to external link
* feat: add comments explaining async state
* fix: test updates
* fix: nits
* fix: design nits
* fix: reduce nesting
* fix: address comments
* test: remove line from test for debugging
* fix: update tests
* fix: address comments
* fix: comments
* fix: update tests
* fix: update tests
* fix: more nesting in test
* feat: correct help center article
* fix: update test
* fix: update e2e test
* fix: update error test
* fix: dont show loader unless onchain processing is happening
* fix: update designs and add comments
* fix: update content in test
* fix: update tests more
* fix: reorganize test code
* fix: mainnet loading indicator on last step
* fix: re-use opacity css code
* fix: testid issue with test
* fix: lint
* fix: modal height and css improvements
* fix: empty
2023-05-25 15:40:42 -07:00
eddie
dd29c59238
feat: permit2 animations WEB-2036 ( #6590 )
...
* test: swap flow cypress tests
* fix: use default parameter
* feat: use Swap Component on TDP
* feat: auto nav for TDP tokens
* chore: merge
* chore: merge
* chore: merge
* chore: merge
* fix: remove extra inputCurrency URL parsing logic
* fix: undo last change
* fix: pass expected chain id to swap component
* fix: search for default tokens on unconnected networks if needed
* test: e2e test for l2 token
* fix: delete irrelevant tests
* fix: address comments
* fix: lint error
* test: update TDP e2e tests
* fix: use pageChainId for filter
* fix: rename chainId
* fix: typecheck
* fix: chainId bug
* fix: chainId required fixes
* fix: bad merge in e2e test
* fix: remove unused test util
* fix: remove unnecessary variable
* fix: token defaults
* fix: address comments
* fix: address comments and fix tests
* fix: e2e test formatting, remove Maybe<>
* fix: remove unused variable
* fix: use feature flag for swap component on TDP
* fix: back button
* feat: copy review screen UI from widgetg
* fix: modal padding
* feat: add final detail row
* fix: remove widget comment
* fix: update unit tests
* fix: code style consistency
* fix: remove padding from AutoColumn
* fix: update snapshots
* fix: use semantic gaps
* fix: more px and gaps
* fix: design feedbacks
* fix: button radius in summary modal
* fix: design nits
* feat: update design of summary modal
* fix: font weight and vertical spacing
* fix: update snapshots
* fix: css nits
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: re-order functions
* wip: move approval to summary modal
* wip: not working
* feat: update permit2 e2e tests
* feat: tests passing
* fix: swap test
* fix: bad merge
* wip: move approval to summary modal
* wip: not working
* feat: PendingModalContent tests
* feat: useMaxAmountIn
* fix: bad merge
* fix: naming
* fix: modal flicker when refetching trade
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: remove step indicators when only one step
* feat: move content into PendingModalContent component
* fix: lint
* chore: merge
* fix: update tests for new modal
* feat: add l2 chain logo to modal
* feat: add unit test
* fix: correct modal state when moving between steps
* fix: correct modal state when moving between steps
* fix: proper error handling of user rejection of swap
* feat: update e2e test
* fix: typecheck
* feat: design updates, state updates
* fix: comments
* fix: code style improvements
* feat: require trade to be defined
* fix: remove extra props from ThemedTexts
* fix: one more trans
* fix: remove unused export
* feat: remove undefined checks and other fixes
* fix: update test
* fix: add missing dollar sign
* fix: remove null check and update test
* fix: remove max width from detail row value
* fix: remove isOpen prop
* fix: isopen
* feat: refactor approval flow into a hook
* fix: custom error type
* fix: testid fix
* fix: text colors
* fix: add comment
* wip: permit2 modal animations
* fix: entrance animations
* feat: step indicator transitions
* feat: icon aniamtions
* feat: fix spinner icon
* fix: re-organize new code
* fix: svg import
* fix: tradeMeaningfullyDiffers improvement and prepareFlow fix
* fix: address comments
* fix: headerContent prop
* fix: change tooltip to external link
* feat: add comments explaining async state
* fix: test updates
* fix: nits
* fix: design nits
* fix: reduce nesting
* fix: address comments
* test: remove line from test for debugging
* fix: update tests
* fix: address comments
* fix: comments
* fix: update tests
* fix: update tests
* fix: more nesting in test
* fix: update test
* fix: update e2e test
* fix: update error test
* fix: dont show loader unless onchain processing is happening
* fix: update designs and add comments
* fix: update content in test
* fix: update tests more
* fix: reorganize test code
* fix: mainnet loading indicator on last step
* fix: re-use opacity css code
* fix: testid issue with test
* fix: lint
* fix: modal height and css improvements
* fix: empty
2023-05-25 15:25:07 -07:00
eddie
8c2a0f1905
feat: update content in Swap Submission Modal ( #6577 )
...
* test: swap flow cypress tests
* fix: use default parameter
* feat: use Swap Component on TDP
* feat: auto nav for TDP tokens
* chore: merge
* chore: merge
* chore: merge
* chore: merge
* fix: remove extra inputCurrency URL parsing logic
* fix: undo last change
* fix: pass expected chain id to swap component
* fix: search for default tokens on unconnected networks if needed
* test: e2e test for l2 token
* fix: delete irrelevant tests
* fix: address comments
* fix: lint error
* test: update TDP e2e tests
* fix: use pageChainId for filter
* fix: rename chainId
* fix: typecheck
* fix: chainId bug
* fix: chainId required fixes
* fix: bad merge in e2e test
* fix: remove unused test util
* fix: remove unnecessary variable
* fix: token defaults
* fix: address comments
* fix: address comments and fix tests
* fix: e2e test formatting, remove Maybe<>
* fix: remove unused variable
* fix: use feature flag for swap component on TDP
* fix: back button
* feat: copy review screen UI from widgetg
* fix: modal padding
* feat: add final detail row
* fix: remove widget comment
* fix: update unit tests
* fix: code style consistency
* fix: remove padding from AutoColumn
* fix: update snapshots
* fix: use semantic gaps
* fix: more px and gaps
* fix: design feedbacks
* fix: button radius in summary modal
* fix: design nits
* feat: update design of summary modal
* fix: font weight and vertical spacing
* fix: update snapshots
* fix: css nits
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: re-order functions
* wip: move approval to summary modal
* wip: not working
* feat: update permit2 e2e tests
* feat: tests passing
* fix: swap test
* fix: bad merge
* wip: move approval to summary modal
* wip: not working
* feat: PendingModalContent tests
* feat: useMaxAmountIn
* fix: bad merge
* fix: naming
* fix: modal flicker when refetching trade
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: remove step indicators when only one step
* feat: move content into PendingModalContent component
* fix: lint
* chore: merge
* fix: update tests for new modal
* feat: add l2 chain logo to modal
* feat: add unit test
* fix: correct modal state when moving between steps
* fix: correct modal state when moving between steps
* fix: proper error handling of user rejection of swap
* feat: update e2e test
* fix: typecheck
* feat: design updates, state updates
* fix: comments
* fix: code style improvements
* feat: require trade to be defined
* fix: remove extra props from ThemedTexts
* fix: one more trans
* fix: remove unused export
* feat: remove undefined checks and other fixes
* fix: update test
* fix: add missing dollar sign
* fix: remove null check and update test
* fix: remove max width from detail row value
* fix: remove isOpen prop
* fix: isopen
* feat: refactor approval flow into a hook
* fix: custom error type
* fix: testid fix
* fix: text colors
* fix: add comment
* fix: tradeMeaningfullyDiffers improvement and prepareFlow fix
* fix: address comments
* fix: headerContent prop
* fix: change tooltip to external link
* feat: add comments explaining async state
* fix: test updates
* fix: nits
* fix: reduce nesting
* fix: address comments
* test: remove line from test for debugging
* fix: update tests
* fix: address comments
* fix: comments
* fix: update tests
* fix: update tests
* fix: more nesting in test
* fix: update test
* fix: update e2e test
* fix: update error test
* fix: update content in test
* fix: reorganize test code
2023-05-25 14:57:04 -07:00
eddie
682fba219d
feat: swap rejection error handling ( #6576 )
...
* test: swap flow cypress tests
* fix: use default parameter
* feat: use Swap Component on TDP
* feat: auto nav for TDP tokens
* chore: merge
* chore: merge
* chore: merge
* chore: merge
* fix: remove extra inputCurrency URL parsing logic
* fix: undo last change
* fix: pass expected chain id to swap component
* fix: search for default tokens on unconnected networks if needed
* test: e2e test for l2 token
* fix: delete irrelevant tests
* fix: address comments
* fix: lint error
* test: update TDP e2e tests
* fix: use pageChainId for filter
* fix: rename chainId
* fix: typecheck
* fix: chainId bug
* fix: chainId required fixes
* fix: bad merge in e2e test
* fix: remove unused test util
* fix: remove unnecessary variable
* fix: token defaults
* fix: address comments
* fix: address comments and fix tests
* fix: e2e test formatting, remove Maybe<>
* fix: remove unused variable
* fix: use feature flag for swap component on TDP
* fix: back button
* feat: copy review screen UI from widgetg
* fix: modal padding
* feat: add final detail row
* fix: remove widget comment
* fix: update unit tests
* fix: code style consistency
* fix: remove padding from AutoColumn
* fix: update snapshots
* fix: use semantic gaps
* fix: more px and gaps
* fix: design feedbacks
* fix: button radius in summary modal
* fix: design nits
* feat: update design of summary modal
* fix: font weight and vertical spacing
* fix: update snapshots
* fix: css nits
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: re-order functions
* wip: move approval to summary modal
* wip: not working
* feat: update permit2 e2e tests
* feat: tests passing
* fix: swap test
* fix: bad merge
* wip: move approval to summary modal
* wip: not working
* feat: PendingModalContent tests
* feat: useMaxAmountIn
* fix: bad merge
* fix: naming
* fix: modal flicker when refetching trade
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: remove step indicators when only one step
* feat: move content into PendingModalContent component
* fix: lint
* chore: merge
* fix: update tests for new modal
* feat: add l2 chain logo to modal
* feat: add unit test
* fix: correct modal state when moving between steps
* fix: correct modal state when moving between steps
* fix: proper error handling of user rejection of swap
* feat: update e2e test
* fix: typecheck
* fix: comments
* fix: code style improvements
* feat: require trade to be defined
* fix: remove extra props from ThemedTexts
* fix: one more trans
* fix: remove unused export
* feat: remove undefined checks and other fixes
* fix: update test
* fix: add missing dollar sign
* fix: remove null check and update test
* fix: remove max width from detail row value
* fix: remove isOpen prop
* fix: isopen
* feat: refactor approval flow into a hook
* fix: custom error type
* fix: testid fix
* fix: add comment
* fix: tradeMeaningfullyDiffers improvement and prepareFlow fix
* fix: address comments
* fix: headerContent prop
* feat: add comments explaining async state
* fix: test updates
* fix: nits
* fix: reduce nesting
* fix: address comments
* test: remove line from test for debugging
* fix: update tests
* fix: address comments
* fix: update tests
* fix: more nesting in test
* fix: update test
* fix: update e2e test
* fix: update error test
* fix: reorganize test code
2023-05-25 14:56:37 -07:00
eddie
0f5e871054
feat: add l2 chain logo to modal ( #6575 )
...
* test: swap flow cypress tests
* fix: use default parameter
* feat: use Swap Component on TDP
* feat: auto nav for TDP tokens
* chore: merge
* chore: merge
* chore: merge
* chore: merge
* fix: remove extra inputCurrency URL parsing logic
* fix: undo last change
* fix: pass expected chain id to swap component
* fix: search for default tokens on unconnected networks if needed
* test: e2e test for l2 token
* fix: delete irrelevant tests
* fix: address comments
* fix: lint error
* test: update TDP e2e tests
* fix: use pageChainId for filter
* fix: rename chainId
* fix: typecheck
* fix: chainId bug
* fix: chainId required fixes
* fix: bad merge in e2e test
* fix: remove unused test util
* fix: remove unnecessary variable
* fix: token defaults
* fix: address comments
* fix: address comments and fix tests
* fix: e2e test formatting, remove Maybe<>
* fix: remove unused variable
* fix: use feature flag for swap component on TDP
* fix: back button
* feat: copy review screen UI from widgetg
* fix: modal padding
* feat: add final detail row
* fix: remove widget comment
* fix: update unit tests
* fix: code style consistency
* fix: remove padding from AutoColumn
* fix: update snapshots
* fix: use semantic gaps
* fix: more px and gaps
* fix: design feedbacks
* fix: button radius in summary modal
* fix: design nits
* feat: update design of summary modal
* fix: font weight and vertical spacing
* fix: update snapshots
* fix: css nits
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: re-order functions
* wip: move approval to summary modal
* wip: not working
* feat: update permit2 e2e tests
* feat: tests passing
* fix: swap test
* fix: bad merge
* wip: move approval to summary modal
* wip: not working
* feat: PendingModalContent tests
* feat: useMaxAmountIn
* fix: bad merge
* fix: naming
* fix: modal flicker when refetching trade
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: remove step indicators when only one step
* feat: move content into PendingModalContent component
* fix: lint
* chore: merge
* fix: update tests for new modal
* feat: add l2 chain logo to modal
* feat: add unit test
* fix: correct modal state when moving between steps
* fix: comments
* fix: code style improvements
* feat: require trade to be defined
* fix: remove extra props from ThemedTexts
* fix: one more trans
* fix: remove unused export
* feat: remove undefined checks and other fixes
* fix: update test
* fix: add missing dollar sign
* fix: remove null check and update test
* fix: remove max width from detail row value
* fix: remove isOpen prop
* fix: isopen
* feat: refactor approval flow into a hook
* fix: testid fix
* fix: tradeMeaningfullyDiffers improvement and prepareFlow fix
* fix: address comments
* fix: headerContent prop
* feat: add comments explaining async state
* fix: test updates
* fix: nits
* fix: reduce nesting
* fix: address comments
* test: remove line from test for debugging
* fix: update tests
* fix: address comments
* fix: update tests
* fix: more nesting in test
* fix: update test
* fix: reorganize test code
2023-05-25 14:14:35 -07:00
eddie
07527bab26
test: permit2 flow component tests ( #6551 )
...
* test: swap flow cypress tests
* fix: use default parameter
* feat: use Swap Component on TDP
* feat: auto nav for TDP tokens
* chore: merge
* chore: merge
* chore: merge
* chore: merge
* fix: remove extra inputCurrency URL parsing logic
* fix: undo last change
* fix: pass expected chain id to swap component
* fix: search for default tokens on unconnected networks if needed
* test: e2e test for l2 token
* fix: delete irrelevant tests
* fix: address comments
* fix: lint error
* test: update TDP e2e tests
* fix: use pageChainId for filter
* fix: rename chainId
* fix: typecheck
* fix: chainId bug
* fix: chainId required fixes
* fix: bad merge in e2e test
* fix: remove unused test util
* fix: remove unnecessary variable
* fix: token defaults
* fix: address comments
* fix: address comments and fix tests
* fix: e2e test formatting, remove Maybe<>
* fix: remove unused variable
* fix: use feature flag for swap component on TDP
* fix: back button
* feat: copy review screen UI from widgetg
* fix: modal padding
* feat: add final detail row
* fix: remove widget comment
* fix: update unit tests
* fix: code style consistency
* fix: remove padding from AutoColumn
* fix: update snapshots
* fix: use semantic gaps
* fix: more px and gaps
* fix: design feedbacks
* fix: button radius in summary modal
* fix: design nits
* feat: update design of summary modal
* fix: font weight and vertical spacing
* fix: update snapshots
* fix: css nits
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: re-order functions
* wip: move approval to summary modal
* wip: not working
* feat: update permit2 e2e tests
* feat: tests passing
* fix: swap test
* fix: bad merge
* wip: move approval to summary modal
* wip: not working
* feat: PendingModalContent tests
* feat: useMaxAmountIn
* fix: bad merge
* fix: naming
* fix: modal flicker when refetching trade
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: remove step indicators when only one step
* feat: move content into PendingModalContent component
* fix: lint
* chore: merge
* fix: update tests for new modal
* fix: correct modal state when moving between steps
* fix: comments
* fix: code style improvements
* feat: require trade to be defined
* fix: remove extra props from ThemedTexts
* fix: one more trans
* fix: remove unused export
* feat: remove undefined checks and other fixes
* fix: update test
* fix: add missing dollar sign
* fix: remove null check and update test
* fix: remove max width from detail row value
* fix: remove isOpen prop
* fix: isopen
* feat: refactor approval flow into a hook
* fix: testid fix
* fix: tradeMeaningfullyDiffers improvement and prepareFlow fix
* fix: address comments
* feat: add comments explaining async state
* fix: test updates
* fix: nits
* fix: reduce nesting
* fix: address comments
* test: remove line from test for debugging
* fix: update tests
* fix: update tests
* fix: more nesting in test
* fix: update test
* fix: reorganize test code
2023-05-25 14:13:55 -07:00
eddie
7934777fa2
feat: permit2 flow updates ( #6538 )
...
* test: swap flow cypress tests
* fix: use default parameter
* feat: use Swap Component on TDP
* feat: auto nav for TDP tokens
* chore: merge
* chore: merge
* chore: merge
* chore: merge
* fix: remove extra inputCurrency URL parsing logic
* fix: undo last change
* fix: pass expected chain id to swap component
* fix: search for default tokens on unconnected networks if needed
* test: e2e test for l2 token
* fix: delete irrelevant tests
* fix: address comments
* fix: lint error
* test: update TDP e2e tests
* fix: use pageChainId for filter
* fix: rename chainId
* fix: typecheck
* fix: chainId bug
* fix: chainId required fixes
* fix: bad merge in e2e test
* fix: remove unused test util
* fix: remove unnecessary variable
* fix: token defaults
* fix: address comments
* fix: address comments and fix tests
* fix: e2e test formatting, remove Maybe<>
* fix: remove unused variable
* fix: use feature flag for swap component on TDP
* fix: back button
* feat: copy review screen UI from widgetg
* fix: modal padding
* feat: add final detail row
* fix: remove widget comment
* fix: update unit tests
* fix: code style consistency
* fix: remove padding from AutoColumn
* fix: update snapshots
* fix: use semantic gaps
* fix: more px and gaps
* fix: design feedbacks
* fix: button radius in summary modal
* fix: design nits
* feat: update design of summary modal
* fix: font weight and vertical spacing
* fix: update snapshots
* fix: css nits
* fix: modal flicker when refetching trade
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: remove step indicators when only one step
* feat: move content into PendingModalContent component
* fix: lint
* fix: correct modal state when moving between steps
* fix: comments
* fix: code style improvements
* feat: require trade to be defined
* fix: remove extra props from ThemedTexts
* fix: one more trans
* fix: remove unused export
* feat: remove undefined checks and other fixes
* fix: update test
* fix: add missing dollar sign
* fix: remove null check and update test
* fix: remove max width from detail row value
* fix: remove isOpen prop
* fix: isopen
* feat: refactor approval flow into a hook
* fix: tradeMeaningfullyDiffers improvement and prepareFlow fix
* fix: address comments
* feat: add comments explaining async state
* fix: nits
* fix: address comments
* feat: permit2 e2e tests (#6541 )
* wip: move approval to summary modal
* wip: not working
* feat: working
* fix: fix flow
* feat: simplify states and build new modal UI
* feat: todos and differs fix
* feat: update tx status modal
* feat: split up approve and permit
* feat: error state
* feat: update success and error states
* feat: undo changes to TxConfirmationModal
* feat: re-order functions
* wip: move approval to summary modal
* wip: not working
* feat: update permit2 e2e tests
* feat: tests passing
* fix: swap test
* fix: bad merge
* chore: merge
* fix: update tests for new modal
* fix: testid fix
* fix: test updates
* fix: reduce nesting
* test: remove line from test for debugging
* fix: update tests
* fix: more nesting in test
* fix: update test
* fix: reorganize test code
2023-05-25 13:49:27 -07:00
Zach Pomerantz
2415a1e3cd
test(e2e): improve hardhat configuration ( #6650 )
...
build: cache hardhat cache
2023-05-25 11:53:39 -07:00
Nate Wienert
1ba796a895
build: add vscode settings for default formatter ( #6644 )
...
build: add vscode settings for default formatter to be dbaeumer.vscode-eslint
2023-05-25 08:22:51 -10:00
Zach Pomerantz
4446eb9b84
fix: include sw metric with web vitals ( #6646 )
2023-05-25 10:12:20 -07:00
Jordan Frankfurt
d23b6e5da6
fix: remove app advert on mobile safari ( #6630 )
...
Co-authored-by: Jordan Frankfurt <jordan@CORN-Jordan-949.frankfurt>
2023-05-25 10:36:57 -05:00
Zach Pomerantz
44c355c7f0
build: caching i18n extractor ( #6619 )
...
* fix: do not attempt to cache i18n:extract
* fix: i18n extraction
* docs: improve comments
2023-05-24 14:23:40 -07:00
Vignesh Mohankumar
e4a9764a12
fix: increase useBestTrade debounce time ( #6631 )
...
* fix: increase useBestTrade debounce time
* reduce
* increase
* 350
* fix
2023-05-24 14:44:18 -04:00
Mike Grabowski
303fa15240
feat: show affordance in swap UI when we can't fetch usd quote ( #6622 )
...
* initial commit:
* add todo to linear
2023-05-24 22:32:53 +04:00
eddie
d180aef306
fix: no-undefined-or in object field types ( #6640 )
2023-05-24 11:31:40 -07:00
Mike Grabowski
c07c401189
feat: add animation to Settings menu ( #6617 )
...
* feat: add price impact back
* chore: update tes tname
* chore: update snapshot for price impact
* fix
* fix
* update snapshot after rebase
* update snapshot
* chore: finish
* chore: remove snapshot
* feat: add test matcher
* cleanup
* chore: add animation test
* add comment
* update comment
2023-05-24 22:02:59 +04:00
Zach Pomerantz
65d91eb363
build: use repository slack secret ( #6639 )
2023-05-24 13:15:28 -04:00
Jordan Frankfurt
bd4042aa16
chore: update pr template ( #6634 )
...
Co-authored-by: Jordan Frankfurt <jordan@CORN-Jordan-949.frankfurt>
2023-05-23 14:53:07 -07:00
github-actions[bot]
1dcafd2f2d
chore(i18n): new Crowdin translations ( #6215 )
...
* chore(i18n): synchronize translations from crowdin [skip ci]
* chore: trigger actions
---------
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Zach Pomerantz <zzmp@uniswap.org>
2023-05-23 14:39:58 -07:00
Jordan Frankfurt
66fcdb4465
feat: improve yarn prepare scripts ( #6609 )
...
* feat: improve yarn prepare scripts
* reset yarn.lock to main
* pr feedback
* Update scripts/prepare.js
Co-authored-by: Zach Pomerantz <zzmp@uniswap.org>
* Update scripts/prepare.js
Co-authored-by: Zach Pomerantz <zzmp@uniswap.org>
* Update scripts/prepare.js
Co-authored-by: Zach Pomerantz <zzmp@uniswap.org>
* Update scripts/prepare.js
Co-authored-by: Zach Pomerantz <zzmp@uniswap.org>
* Update scripts/prepare.js
Co-authored-by: Zach Pomerantz <zzmp@uniswap.org>
* Update scripts/prepare.js
Co-authored-by: Zach Pomerantz <zzmp@uniswap.org>
* Update scripts/prepare.js
Co-authored-by: Zach Pomerantz <zzmp@uniswap.org>
* pr feedback
* switch to using concurrently
* yarn dedupe
---------
Co-authored-by: Jordan Frankfurt <jordan@CORN-Jordan-949.frankfurt>
Co-authored-by: Jordan Frankfurt <jordan@corn-jordan-949.lan>
Co-authored-by: Zach Pomerantz <zzmp@uniswap.org>
2023-05-23 16:07:05 -05:00
Jack Short
e398e8b950
fix: allow unsupported chain in pwat ( #6629 )
...
chore: allow unsupported chain in pwat
2023-05-23 13:36:28 -04:00
Tina
6424fdfbcd
fix: Simplify event logging for SWAP_QUOTE_RECEIVED ( #6628 )
...
* simplify event logging
* remove unused function parameter
2023-05-23 11:06:18 -04:00
eddie
95814e3271
fix: prevent race condition for swap state ( #6624 )
2023-05-22 15:57:17 -07:00
Jack Short
caa2524e27
feat: [DetailsV2] instant buy ( #6599 )
...
* initial impl
* removing isopen change
* stopping refetching
* shared button
* pending animiation
* updating shared
* updating snapshots
* adding disabled state
* isLoading in hook
* pulling out ternary
* removing fragment
* separate file for offer button
* fixing price diff check
* remove unnecessary export
* changing name to useBuyAssetCallback
2023-05-22 18:28:48 -04:00
Zach Pomerantz
d28a4b34cd
fix: do not attempt to cache i18n:extract ( #6616 )
2023-05-22 14:03:11 -07:00
cartcrom
f3a80c6272
feat: special case arb search ( #6584 )
...
* feat: special case arb search
* fix: check both current and existing token
2023-05-22 12:40:46 -04:00
Zach Pomerantz
b89ee36448
test(e2e): attempt to de-flake ( #6611 )
...
* test(e2e): improve memory mgmt
* test(e2e): record flakes
* test(e2e): simplify tests in attempt to de-flake
* test(e2e): more simplification
* test(e2e): disable transaction popup checks
* test(e2e): better wrap assertions
* test(e2e): always assert both inputs
2023-05-22 09:02:54 -07:00
Vignesh Mohankumar
fbc55db937
chore: remove chunkResponseStatus tag ( #6586 )
...
* chore: remove chunkResponseStatus tag
* lint
2023-05-21 17:25:58 -04:00
Jordan Frankfurt
835c62acfa
fix: use ephemeral props for styled component ( #6607 )
...
* fix: use ephemeral props for styled component
* add
2023-05-20 16:55:37 -05:00
Zach Pomerantz
8fe7c7a0a7
build: notify from notify/test ( #6597 )
...
* build: notify from notify/test
* debug
* debug2
* revert debugs
2023-05-19 12:24:11 -07:00
Tina
41113e6e41
fix: Use client side router only for price fetching ( #6604 )
...
use client side router only for price fetching
2023-05-19 13:35:29 -04:00
Mike Grabowski
58b25d29a9
feat: expand settings by default when custom values are set ( #6603 )
...
feat: expand by default
2023-05-19 21:35:02 +04:00
Zach Pomerantz
a2db3e2719
test(e2e): configure Cypress to post PR status comments ( #6591 )
2023-05-19 06:32:42 -07:00
Mike Grabowski
b62f9066a7
fix: add price impact back ( #6581 )
...
* feat: add price impact back
* chore: update tes tname
* chore: update snapshot for price impact
* fix
* fix
* update snapshot after rebase
* update snapshot
2023-05-19 09:24:06 +04:00
Zach Pomerantz
258f22e037
build: continue-on-error for slack notifications ( #6600 )
2023-05-18 15:30:43 -07:00
