added progress percentage for events fetching #6

2022-10-06T23:15:42+03:00

Freezy commented

2022-10-06 23:15:42 +03:00

(Migrated from development.tornadocash.community)

Explanation

If the last cached event is many blocks behind (over 100k) the use should know the current fetching status/progress.
To solve this, a progress indicator has been added to the loader. It shows the progress percentage based on the number of blocks needed to reach the current block. Without this indicator, the user could think that the website is stuck while instead he only has to wait.

Screenshots/Screencaps

## Explanation  If the last cached event is many blocks behind (over 100k) the use should know the current fetching status/progress. To solve this, a progress indicator has been added to the loader. It shows the progress percentage based on the number of blocks needed to reach the current block. Without this indicator, the user could think that the website is stuck while instead he only has to wait. ## Screenshots/Screencaps ![image](/attachments/19fceb21-f066-4c2b-b9d5-48c8347ce651)

gozzy (Migrated from development.tornadocash.community) approved these changes 2022-10-13 01:35:03 +03:00

store/loading.js

						
				@ -6,1 +2,3 @@

				    type: null

				    return {

				      message: '',

				      progress: '',

gozzy (Migrated from development.tornadocash.community) commented

2022-10-13 16:15:19 +03:00

Let's keep state variable's types consistent, uninitialised loading state could be better detected using a default value of -1.

Let's keep state variable's types consistent, uninitialised loading state could be better detected using a default value of `-1`.

gozzy commented

2022-10-13 01:39:14 +03:00

(Migrated from development.tornadocash.community)

So the PR should not address updating the cache, which seems to be have mistakenly done. I advise removing these associated files as they are not relative to the feature request. Also, see comment about maintaining types on state variables.

I see no conflicts otherwise.

So the PR should not address updating the cache, which seems to be have mistakenly done. I advise removing these associated files as they are not relative to the feature request. Also, see comment about maintaining types on state variables. I see no conflicts otherwise.