Seungbae.yu
2697e44d81
all: change format 0x%x
to %#x
( #25221 )
2022-07-04 11:03:32 +03:00
aaronbuchwald
953a29f5fd
Replace fmt.Errorf with errors.New in abi argument ( #25181 )
...
Replace unnecessary fmt.Errorf with errors.New in accounts/abi/argument.go
2022-07-04 09:21:00 +02:00
Péter Szilágyi
de1cecb22e
eth/catalyst: disallow importing blocks via newPayload during snap sync ( #25210 )
...
* eth/catalyst: disallow importing blocks via newPayload during snap sync
* eth/catalyst: make tests pass by using full sync only
* eth/catalysts: make the import delay a bit cleaner
* eth/catalyst: fix typo
Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
2022-07-01 14:38:26 +03:00
Péter Szilágyi
692bfd1bf8
Merge pull request #25206 from dbadoy/master
...
common/prque: fix typo
2022-06-30 09:23:34 +03:00
Seungbae.yu
a1cb7282b0
common/prque: fix typo
2022-06-30 13:24:04 +09:00
Felix Lange
5e252282c0
params: begin v1.10.21 release cycle
2022-06-30 00:30:39 +02:00
Felix Lange
8f2416a89a
params: go-ethereum v1.10.20 stable
2022-06-30 00:27:43 +02:00
Felix Lange
75ebeb7fe0
build/deb: fix auto-completion install paths ( #25204 )
2022-06-29 23:19:30 +02:00
Felix Lange
63b2d49b5b
build: upgrade to golangci-lint v1.46.2 ( #25202 )
...
This upgrade is required to fix lint issues with urfave/cli/v2, which
uses generics when built with Go 1.18
2022-06-29 20:49:04 +02:00
willian.eth
ea0bf08547
build: fix auto-completion scripts and include them in .deb package ( #25195 )
...
Co-authored-by: Felix Lange <fjl@twurst.com>
2022-06-29 19:41:39 +02:00
Marius van der Wijden
d12b1a91cd
consensus/beacon: check that only the latest pow block is valid ttd block ( #25187 )
...
* consensus/beacon: check that only the latest pow block is valid ttd block
* consensus/beacon: move verification to async function
* consensus/beacon: fix verifyTerminalPoWBlock, add test cases
* consensus/beacon: cosmetic changes
* consensus/beacon: apply karalabe's fixes
2022-06-29 15:13:19 +03:00
Seungbae.yu
c2070f8d15
common: increase StorageSize test coverage ( #25188 )
2022-06-29 12:13:00 +02:00
lightclient
3e693e1ef6
internal/ethapi: return chain id for EIP-155 legacy txs ( #25155 )
2022-06-29 11:58:59 +02:00
Andre Patta
9ecf8a97a9
cmd/utils: fix applying bootstrap nodes from config file ( #25174 )
2022-06-29 11:57:12 +02:00
aaronbuchwald
300f6121ad
core/rawdb: simplify TestDiskSeek to use memorydb ( #25182 )
2022-06-29 11:54:42 +02:00
Ruohui Wang
3f712e7447
core/rawdb: fix typo in comment ( #25191 )
2022-06-29 11:47:33 +02:00
Guillaume Ballet
d1890aa402
fix: linter warning ( #25192 )
2022-06-29 10:54:57 +02:00
zeim839
9a5c1000c7
cmd/geth, p2p: add support for custom discovery UDP port ( #24979 )
...
This adds a new flag to set the discovery port to be different from
the TCP listener port.
Co-authored-by: Felix Lange <fjl@twurst.com>
2022-06-28 17:25:47 +02:00
Marius van der Wijden
1438e7c324
params: set TTD for sepolia testnet ( #25179 )
2022-06-28 14:48:13 +02:00
willian.eth
52ed3570c4
cmd: migrate to urfave/cli/v2 ( #24751 )
...
This change updates our urfave/cli dependency to the v2 branch of the library.
There are some Go API changes in cli v2:
- Flag values can now be accessed using the methods ctx.Bool,
ctx.Int, ctx.String, ... regardless of whether the flag is 'local' or
'global'.
- v2 has built-in support for flag categories. Our home-grown category
system is removed and the categories of flags are assigned as part of
the flag definition.
For users, there is only one observable difference with cli v2: flags must now
strictly appear before regular arguments. For example, the following command is
now invalid:
geth account import mykey.json --password file.txt
Instead, the command must be invoked as follows:
geth account import --password file.txt mykey.json
2022-06-27 18:22:36 +02:00
lightclient
119f955686
all: remove public
field from rpc.API
( #25059 )
...
all: remove public field from rpc.API
2022-06-27 13:33:13 +03:00
lightclient
c7f485d9e5
internal/ethapi: add note about eth_chainId compatibility with EIP-695 ( #25168 )
...
Co-authored-by: Felix Lange <fjl@twurst.com>
2022-06-25 21:34:21 +02:00
lightclient
647c6f2db6
internal/ethapi: always return chain id ( #25166 )
...
The error was introduced in PR #21686 , but there is no good reason to enforce sync
in this method, and it causes issues with EL/CL integration.
2022-06-24 18:03:13 +02:00
int88
e620fa3980
eth: fix typo ( #25161 )
2022-06-24 15:28:01 +03:00
Sina Mahmoodi
6135c688b8
eth/tracers: optimize goja buffer conversion ( #25156 )
...
This changes the []byte <-> Uint8Array conversion to use an
ArrayBuffer, avoiding inefficient copying of the slice data in Goja.
Co-authored-by: Felix Lange <fjl@twurst.com>
2022-06-23 18:11:47 +02:00
ucwong
0f044f3433
go.mod: upgrade to latest goleveldb ( #25067 )
...
Co-authored-by: Felix Lange <fjl@twurst.com>
2022-06-23 10:35:27 +02:00
aaronbuchwald
68420e1aa5
core: fix typo in txpool ( #25149 )
...
Fix typo in txPool truncateQueue comment
2022-06-22 22:51:45 +02:00
rjl493456442
7c7cd410d1
eth, miner: retrieve mining state from live database ( #25139 )
...
* miner: retrieve mining state from live database
* eth/catalyst: ignore stale fcu events from cl
2022-06-22 14:59:55 +03:00
Zachinquarantine
f49e298330
README,rpc: remove mention of "shh" RPC API ( #25137 )
2022-06-21 11:59:02 +02:00
Sina Mahmoodi
f20a569265
cmd/geth: drop geth js command ( #25000 )
...
* cmd/geth: drop js command
* cmd: simplify ipc path determination for attach
* Add deprecation warning for js
* rm testdata for exec
* fix account unlock test cases
* Update cmd/geth/consolecmd.go
Co-authored-by: Martin Holst Swende <martin@swende.se>
* fix
Co-authored-by: Martin Holst Swende <martin@swende.se>
2022-06-21 12:16:05 +03:00
lightclient
10dc5dce08
all: remove concept of public/private API definitions ( #25053 )
...
* internal/ethapi: rename PublicEthereumAPI to EthereumAPI
* eth: rename PublicEthereumAPI to EthereumAPI
* internal/ethapi: rename PublicTxPoolAPI to TxPoolAPI
* internal/ethapi: rename PublicAccountAPI to EthereumAccountAPI
* internal/ethapi: rename PrivateAccountAPI to PersonalAccountAPI
* internal/ethapi: rename PublicBlockChainAPI to BlockChainAPI
* internal/ethapi: rename PublicTransactionPoolAPI to TransactionAPI
* internal/ethapi: rename PublicDebugAPI to DebugAPI
* internal/ethapi: move PrivateDebugAPI methods to DebugAPI
* internal/ethapi: rename PublicNetAPI to NetAPI
* les: rename PrivateLightServerAPI to LightServerAPI
* les: rename PrivateLightAPI to LightAPI
* les: rename PrivateDebugAPI to DebugAPI
* les: rename PublicDownloaderAPI to DownloaderAPI
* eth,les: rename PublicFilterAPI to FilterAPI
* eth: rename PublicMinerAPI to MinerAPI
* eth: rename PublicDownloaderAPI to DownloaderAPI
* eth: move PrivateMinerAPI methods to MinerAPI
* eth: rename PrivateAdminAPI to AdminAPI
* eth: rename PublicDebugAPI to DebugAPI
* eth: move PrivateDebugAPI methods to DebugAPI
* node: rename publicAdminAPI to adminAPI
* node: move privateAdminAPI methods to adminAPI
* node: rename publicWeb3API to web3API
* eth,internal/ethapi: sync comments with previous renamings
2022-06-21 12:05:43 +03:00
aaronbuchwald
241dd27300
trie: fix size accounting in cleaner ( #25007 )
...
Decrease children size instead of dirties size when marking dirties as cleaned up in trie cleaner
2022-06-21 12:00:37 +03:00
Zachinquarantine
ad15050c7f
cmd/faucet: add sepolia network support ( #25128 )
...
cmd/faucet: Add Sepolia network support to faucet
2022-06-20 10:40:06 +02:00
Sina Mahmoodi
d39f0cce71
internal/ethapi: remove SignAndSendTransaction ( #25111 )
2022-06-20 10:38:46 +02:00
Zachinquarantine
c776029c6c
cmd/faucet: more verbose message about private posts ( #25129 )
...
* cmd/faucet: Add error message for private posts
Fixes #22631
* grammar
2022-06-20 10:20:32 +02:00
Martin Holst Swende
21129ec838
node: make jwt tests less time-dependent ( #25120 )
2022-06-20 10:10:25 +02:00
Martin Holst Swende
01e5e9c2c3
tests/fuzzers/rlp: avoid very large input ( #25109 )
...
The oss-fuzz engine crashes due to stack overflow decoding a large nested
structure into a interface{}. This PR limits the size of the input data, so
should avoid such crashes.
2022-06-17 00:44:30 +02:00
Kosuke Taniguchi
ba99e19215
internal/ethapi: add comment explaining return of nil instead of error ( #25097 )
...
Co-authored-by: Felix Lange <fjl@twurst.com>
2022-06-16 17:08:25 +02:00
Péter Szilágyi
67454df08b
params: begin v1.10.20 release cycle
2022-06-15 15:56:01 +03:00
Péter Szilágyi
23bee16208
params: release Geth v1.10.19
2022-06-15 15:49:45 +03:00
Marius van der Wijden
d78d302f3d
node: add info message when JWT secret is loaded ( #25095 )
...
Co-authored-by: Felix Lange <fjl@twurst.com>
2022-06-15 14:35:53 +02:00
Marius van der Wijden
d8f963811d
cmd, params: implement Gray Glacier hard-fork (EIP-5133) ( #25088 )
...
* cmd/geth, params: implement Gray Glacier (EIP-5133)
* cmd/evm: add gray glacier tests
* params: nitpicks
* params: fixes
2022-06-15 14:10:38 +03:00
rjl493456442
30602163d5
eth: introduce eth67 protocol ( #24093 )
...
The new protocol version removes support for GetNodeData.
See https://eips.ethereum.org/EIPS/eip-4938 for more information.
Co-authored-by: Felix Lange <fjl@twurst.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
2022-06-15 12:56:47 +02:00
lightclient
3273ad1a58
eth: add missing period at end of sentences ( #25058 )
...
eth: add missing periods on end of comments
2022-06-15 09:29:23 +02:00
lmittmann
bc013bc42e
all: prefer new(big.Int)
over big.NewInt(0)
( #25087 )
...
minor performance improvement: `big.NewInt(0).Xxx` -> `new(big.Int).Xxx`
2022-06-14 15:09:48 +03:00
Marius van der Wijden
8cfd1214b7
common: improve pretty duration regex ( #25073 )
...
* common: improve pretty duration regex
* common: improve pretty duration regex
2022-06-14 14:08:43 +02:00
s7v7nislands
6ad620d642
cmd/ethkey: use accounts.TextHash ( #25069 )
2022-06-14 13:47:11 +02:00
lightclient
1cf58c7b81
readme,eth: remove references to eth.wiki ( #25086 )
2022-06-14 12:59:05 +02:00
Ivan Aracki
f74bb3a3bf
cmd/utils: update --ropsten description ( #25078 )
2022-06-14 10:24:29 +02:00
Martin Holst Swende
a907d7e81a
all: more linters ( #24783 )
...
This enables the following linters
- typecheck
- unused
- staticcheck
- bidichk
- durationcheck
- exportloopref
- gosec
WIth a few exceptions.
- We use a deprecated protobuf in trezor. I didn't want to mess with that, since I cannot meaningfully test any changes there.
- The deprecated TypeMux is used in a few places still, so the warning for it is silenced for now.
- Using string type in context.WithValue is apparently wrong, one should use a custom type, to prevent collisions between different places in the hierarchy of callers. That should be fixed at some point, but may require some attention.
- The warnings for using weak random generator are squashed, since we use a lot of random without need for cryptographic guarantees.
2022-06-13 16:24:45 +02:00