Commit Graph

391 Commits

Author SHA1 Message Date
Marius van der Wijden
61214ee283
Update code-review-guidelines.md
Removing this whitespace might make the final page look cleaner (Not as much whitespace between terminology and process)
2022-12-12 14:55:23 +01:00
Joseph Cook
db0b46953b
Merge pull request #149 from MariusVanDerWijden/patch-1
Update contribute to the website text
2022-12-12 12:58:26 +00:00
Marius van der Wijden
50254f6e80
Update contributing.md 2022-12-12 13:50:07 +01:00
Corwin Smith
4315911af4
Merge pull request #139 from ethereum/empty-state-releases
feat: add empty state for platforms without releases
2022-12-09 03:56:48 +01:00
Corwin Smith
4dee3f52f1
Merge pull request #140 from ethereum/add-missing-link-prop
fix: adds missing legacyBehavior prop [Fixes #98]
2022-12-09 03:53:38 +01:00
Corwin Smith
7904e5878e
Merge branch 'master' into add-missing-link-prop 2022-12-09 03:51:36 +01:00
Corwin Smith
a66cffef76
Merge pull request #141 from ethereum/buttons-hover-color
Buttons hover color
2022-12-09 03:43:09 +01:00
Nicolás Quiroz
026757a5db chore: prettier 2022-12-07 18:41:50 -03:00
Nicolás Quiroz
640b72abc6 fix: add :hover color for hero buttons on dark mode 2022-12-07 18:40:13 -03:00
Nicolás Quiroz
d8996d1c95 fix: adds missing legacyBehavior prop 2022-12-07 17:09:43 -03:00
Nicolás Quiroz
d71e3177d8 Merge branch 'master' of github.com:ethereum/geth-website into empty-state-releases 2022-12-07 16:59:56 -03:00
Nicolás Quiroz
527dad3635 fix: borderBottom on DownloadsTable 2022-12-07 16:59:44 -03:00
Nicolás Quiroz
af86168c2f feat: add empty state for platforms without releases 2022-12-07 14:30:09 -03:00
Paul Wackerow
11035bf0c4
adjusts light primary to green.700 for contrast (#137)
Improves contrast ratio when paired with yellow.50 and removes browser a11y warnings
2022-12-07 14:26:23 -03:00
Paul Wackerow
faa0640465
update green.900 value (#135)
used for button background; increases contrast ratio
2022-12-07 11:57:25 -03:00
Paul Wackerow
56b9963afd
Markdown header margin fix [Fixes #83] (#120)
* expand parseHeadingId

Will produce a kebab-case heading ID from string if none explicitly declared in the markdown. Always returns an object with the children, title and headingId.

* remove redundant code from MDComponents.tsx

parseHeadingIds now always returns an object with an ID, removing need for conditionals here

* Use Box instead of flex Stack for MDX content

Allows stacked vertical margins to properly collapse into each other

* fix: h2 top margin to 3rem on mobile

* remove unneeded line

* extract and rename getKebabCaseFromName util fn

* Update src/pages/[...slug].tsx

* Update src/utils/parseHeadingId.ts

Co-authored-by: Corwin Smith <cssmittys@gmail.com>

* move constant inside function

make variable name all caps as a string constant

* clean up utils/index.ts to abc order

Co-authored-by: Corwin Smith <cssmittys@gmail.com>
2022-12-06 17:04:09 -03:00
Nicolás Quiroz
332e972397
fix: external links (#133)
* fix: footer external links

* fix: ButtonLinkSecondary external links

* fix: docs external links
2022-12-06 17:02:55 -03:00
Corwin Smith
4a464da994
Merge pull request #122 from ethereum/document-nav-spacing
Fix spacing for DocumentNav links [Fixes #87]
2022-12-06 19:07:48 +01:00
Paul Wackerow
4f45c02127
Merge branch 'master' into document-nav-spacing 2022-12-06 10:04:33 -08:00
Corwin Smith
50b50e853c
Merge pull request #128 from ethereum/breadcrumbHeaderBug
[Logic bug] - Breadcrumbs contains header id
2022-12-06 18:56:13 +01:00
Corwin Smith
7e9e22a671 remove margin styles for document-nav-link in textStyles.ts 2022-12-06 10:54:50 -07:00
Corwin Smith
d93e4373e2
Update src/components/UI/docs/DocumentNav.tsx
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
2022-12-06 10:53:11 -07:00
Corwin Smith
5186a1f74f
Update src/components/UI/docs/Breadcrumbs.tsx
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
2022-12-06 10:35:48 -07:00
Corwin Smith
9107cf3988
Update src/components/UI/docs/Breadcrumbs.tsx
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
2022-12-06 10:35:44 -07:00
Paul Wackerow
9bbcd71078
Fix hover for DocumentNav links [Fixes #73] (#107)
* fix hover for DocumentNav links [Fixes #73]

* use Box instead of flex Stack

Allows vertical margins of children to collapse into each other

* Revert "use Box instead of flex Stack"

This reverts commit a4811127ccd7424da8f51e2a056aee447fc5db08.

* add :focus and :active states
2022-12-06 10:46:18 -03:00
Paul Wackerow
892c743b78
Use long month formatting for last edit date [Fixes #86] (#121)
* use long month formatting for last edit date

* last -> Last

* Update src/pages/[...slug].tsx

Co-authored-by: Nicolás Quiroz <nh.quiroz@gmail.com>

Co-authored-by: Corwin Smith <cssmittys@gmail.com>
Co-authored-by: Nicolás Quiroz <nh.quiroz@gmail.com>
2022-12-06 10:43:12 -03:00
Paul Wackerow
bbd4a31bad
add max width of 100% to md content on mobile (#130) 2022-12-06 10:35:53 -03:00
Joe
9d3be9b1d6 Merge branch 'master' of https://github.com/ethereum/geth-website 2022-12-06 11:14:19 +00:00
Joe
e983c7e64d update redirects and fix line break on cli page 2022-12-06 11:14:17 +00:00
Paul Wackerow
93c255ce39
Adjust link styling for various states [Fixes #89] (#129)
* fix: link styling for various states

updates hover/active/focus link states to match design system

* hover underline color to secondary
2022-12-05 21:40:07 -03:00
Corwin Smith
26673626d2
Remove color style for list items, and change first-child to first-of-type based on console error for SSR (#127) 2022-12-05 17:17:11 -03:00
Paul Wackerow
04adbb749b
Merge pull request #116 from ethereum/display-12-releases
fix: show 2 latest releases for linux
2022-12-05 21:00:48 +01:00
Corwin Smith
a11ce6cb8a
Merge pull request #117 from thouravi/patch-1
Extracted the style objects and props into variable
2022-12-05 20:07:11 +01:00
Corwin Smith
5926da4aa7 filter out anchor tag 2022-12-05 11:38:04 -07:00
Paul Wackerow
94cb14b978
Add gap between md content and right nav [Fixes #77] (#110)
* add gap between md content and right nav

* shorten max width of right nav divider

* make DocumentNav width responsive

Existing fixed width was too large after the 2rem of padding was added. Simply making it more narrow made it unnecessarily small on larger screen sizes. Clamp sets a min of chakra-size-40, max of chakra-size-58, while targeting an eighth of the screen width.
2022-12-05 14:13:26 -03:00
Paul Wackerow
1da998a4b6
xs font size for os label on mobile [Fixes #94] (#123) 2022-12-05 13:54:38 -03:00
Nicolás Quiroz
467d139bb0 hotfix: button width 2022-12-05 13:42:09 -03:00
Nicolás Quiroz
e25b87f32d
fix: remove Showing... count message (#118)
* fix: remove Showing... count message

* Update src/pages/downloads.tsx

Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>

* Update src/pages/downloads.tsx

Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>

Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
2022-12-05 13:39:12 -03:00
Paul Wackerow
1f90789712
Link section padding [Fixes #71] (#106)
* rename to LinksList

* add padding after sections in LinksList

* reduce padding between sections to 1.5rem
2022-12-05 13:37:44 -03:00
Paul Wackerow
8b1b80604e
Icon line weight patch [Fixes #70] (#105)
* add custom AddIcon and MinusIcon svgs

* switch DocsLinks to use custom +/- svgs

* fix size of +/- svgs
2022-12-05 13:31:39 -03:00
Nicolás Quiroz
0bddab847d
fix: Show older releases button width on mobile (#125) 2022-12-05 13:28:34 -03:00
Paul Wackerow
2ae5698622
Stylize active docs link [Fixes #74, Fixes #115] (#108)
* add bold for active docs link [Fixes #74]

* Add ::before indicator to active doc link

Removes bold styling per design

* Update documentation-links.yaml

Makes it so `id` is paired with either a `to` field OR a list of `items` but not both

* Updates hover styling for left docs nav

* clean up styling

Removes remaining underlines from links styled as buttons. Cleans up logic for conditionally showing the ::before pseudo element. Makes the ::before indicator slightly larger.

* tweak ::before indicator styling

* tweak ::before indicator styling
2022-12-05 12:13:47 -03:00
Paul Wackerow
e564ae46aa
adjust docs nav gap to 14px per design 2022-12-03 18:50:23 -08:00
Paul Wackerow
7e5c3cacbc
use Box instead of flex Stack for nav items
allows vertical margins of children to properly collapse into one another
2022-12-03 18:50:11 -08:00
Paul Wackerow
3a2a4b1cbf
patch responsive width [Fixes #53] (#104) 2022-12-02 15:07:58 -03:00
Paul Wackerow
41069b3d10
fix broken links (#103) 2022-12-02 14:58:46 -03:00
Paul Wackerow
367e7c6e03
remove any margin on first MD item (#109)
[Fixes #75, issue when articles start with an H2 had extra margin between the H1 section and the starting H2.
2022-12-02 13:56:44 -03:00
Avi Thour
a1ff1fe755
Extracted the style objects and props into variable
Extracted the common style objects and props into variables or constants to avoid repeating the same code and make the code easier to read. 
Instead of repeating the same _hover styles in multiple places, I created a hoverStyles object and used it in each Link component.
2022-12-02 21:49:09 +05:30
Nicolás Quiroz
50bfc2053a fix: show 2 latest releases for linux 2022-12-02 13:18:00 -03:00
Paul Wackerow
123b299345
prevent Header title from wrapping [Fixes #79] (#111) 2022-12-02 11:32:30 -03:00