tornadocontrib/git-arr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

views: branch/paginate: teach "next" link to respect 'max_pages'

Browse Source 
Pagination link "next" does not respect 'max_pages', thus it incorrectly
remains enabled on the final page capped by 'max_pages'. When clicked,
the user is taken to a "404 Page not found" error page, which makes for
a poor user experience.

Fix this problem by teaching the "next" link to respect 'max_pages'.

(As a side-effect, this also causes 'serve' mode to respect 'max_pages',
which was not previously the case. This change of behavior is
appropriate since it brings 'serve' mode, which is intended primarily
for testing, more in line with 'generate' mode.)

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
This commit is contained in:
Eric Sunshine 2015-01-01 16:41:09 -05:00 committed by Alberto Bertogli
parent ac105c8383
commit 7f2f67629f
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
views/branch.html
View File

@ -30,6 +30,7 @@
% if more: % if more:
% commits = commits[:-1] % commits = commits[:-1]
% end % end
% more = more and offset + 1 < repo.info.max_pages
% include paginate more = more, offset = offset % include paginate more = more, offset = offset